bug: Dialog crashes on show

Dialog is broken. Window works ok though.

(SC_SNAPSHOT-2011-06-14/Pro Deployment 2011-06-14)

 new Dialog().show()
com.google.gwt.core.client.JavaScriptException: (TypeError): _1 is undefined
 fileName: http://127.0.0.1:8888/example/sc/modules/ISC_Containers.js
 lineNumber: 321
 stack: isc_Dialog_draw(true)@http://127.0.0.1:8888/example/sc/modules/ISC_Containers.js:321
isc_Canvas_show((void 0),(void 0),(void 0),(void 0),(void 0),(void 0),(void 0),(void 0))@http://127.0.0.1:8888/example/sc/modules/ISC_Core.js:2963
isc_c_Class_invokeSuper([object Object],"show",(void 0),(void 0),(void 0),(void 0))@http://127.0.0.1:8888/example/sc/modules/ISC_Core.js:304
isc_Window_show()@http://127.0.0.1:8888/example/sc/modules/ISC_Containers.js:159
()@http://127.0.0.1:8888:1815
connect("http://127.0.0.1:8888/example.html?gwt.codesvr=127.0.0.1:9997","y0347Mj*uy,E[>MP","127.0.0.1:9997","example","2.1")@:0
((void 0),"example","http://127.0.0.1:8888/example/",0)@http://127.0.0.1:8888/example/hosted.html?example:281
maybeStartModule()@http://127.0.0.1:8888/example/example.nocache.js:39
(-10)@http://127.0.0.1:8888/example/example.nocache.js:263
    at com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:237)
    at com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:129)
    at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:561)
    at com.google.gwt.dev.shell.ModuleSpace.invokeNativeVoid(ModuleSpace.java:289)
    at com.google.gwt.dev.shell.JavaScriptHost.invokeNativeVoid(JavaScriptHost.java:107)
    at com.smartgwt.client.widgets.Canvas.show(Canvas.java)
    at com.example.app.client.Test.test4(Test.java:273)
    at com.example.app.client.example.onModuleLoad(example.java:23)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:396)
    at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:183)
    at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:510)
    at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:352)
    at java.lang.Thread.run(Unknown Source)

Fixed. Note this only affects a custom Dialogs with no buttons, an odd edge case. Any other use of Dialog is fine.

Weird. My code had buttons in it - would it matter if they were embedded in another layout? I was using addItem and adding a VLayout.

Also, another case of developer falling asleep while writing documentation:
http://www.smartclient.com/smartgwtee/javadoc/com/smartgwt/client/widgets/Dialog.html

ok, I guess I should be using setToolbarButtons

That’s already corrected and the developer in question is receiving treatment for narcolepsy.

I just bookmarked the up to date javadoc - I keep looking at the old ones by mistake. (takes memory pills)